@ChrisH

MorphOS version not working for me.
Select directory for pics and then just a grey box where the pictures should be displayed.

_________________
If your nose runs and your feet smell, you're upside down.

@TiredofLife Quote:

Select directory for pics and then just a grey box where the pictures should be displayed

Bah, sounds like my "fix" make the problem worse, since before it displayed stuff (just in the wrong colours)

Since my "fix" was attempting to work-around an OS bug, I'm not sure what else I can do. The fix worked on AROS, which seemingly had the same problem.

QUESTIONS: What version of MOS are you using? Which screen resolution AND depth? Do you have 3D Layers activated? What kind of pictures (file type & origin) did you try? Were you using windowed or full-screen mode? Thanks in advance.

QUESTION: Do you see any filenames displayed (in a grid)? What happens if you double click above the filenames (where the picture thumbnail should be)?

Last edited by ChrisH on 05-Oct-2010 at 10:43 PM.
Last edited by ChrisH on 05-Oct-2010 at 10:40 PM.

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@ChrisH

MOS 2.5
1024x768 16 bit, 3D Layers activated.
Think they were png.
Windowed.
No file names or thumbs.

_________________
If your nose runs and your feet smell, you're upside down.

@TiredofLife Quote:

No file names or thumbs

Ah,ok, this helps a lot. Seems that loading via datatypes is now broken, rather than displaying, so I need to look at what I changed.

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@TiredofLife & other MorphOS users
Please try this version & report back:
http://cshandley.co.uk/temp/PictureAlbum_MOS_test.lha

I undid the only (small) change I could think of. Will be (pleasantly!) surprised if this fixes it...

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@ChrisH

The program does a lot of illegal data access on my mini.
Even before the window is up...

@Develin
I assume that's a "no" about fixing the "no filenames or thumbnails" problem?

What kind of "illegal data accesses"? No problems on AROS or AmigaOS4 :(

EDIT: Do you still get illegal data accesses if you run PictureAlbum from the Shell, with a folder as an argument? e.g.:
Stack 64000
PictureAlbum RAM:

Last edited by ChrisH on 06-Oct-2010 at 11:48 AM.
Last edited by ChrisH on 06-Oct-2010 at 11:44 AM.

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@ChrisH

Crashes at start:

Exception 3 <Illegal Data Access at 8ea0ba8c DSISR 40000000, Load from a not existing Page>

PPCStackFrame History:
StackFrame[ 0].LR-> Address 0x1029725c -> Module Hunk 0 Offset 0x0019725c
StackFrame[ 1].LR-> Address 0x23f944a0 -> PictureAlbum_MorphOS Hunk 1 Offset 0x00026850
StackFrame[ 2].LR-> Address 0x23fbbce0 -> PictureAlbum_MorphOS Hunk 1 Offset 0x0004e090
StackFrame[ 3].LR-> Address 0x23fbdc90 -> PictureAlbum_MorphOS Hunk 1 Offset 0x00050040
StackFrame[ 4].LR-> Address 0x23f6e128 -> PictureAlbum_MorphOS Hunk 1 Offset 0x000004d8
StackFrame[ 5].LR-> Address 0x23f6dfb8 -> PictureAlbum_MorphOS Hunk 1 Offset 0x00000368

Last edited by g_kraszewski on 06-Oct-2010 at 02:02 PM.
Last edited by g_kraszewski on 06-Oct-2010 at 02:01 PM.

_________________
RastPort

@g_kraszewski
Wish I could interpret that debug info, as it might give me a clue to where the problem lies

P.S. I assume this was on MorphOS...

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@ChrisH

Yes, on MorphOS. Now I've tested this test version from post #85. It crashes right after opening the window, after I select a drawer with images. Crash is write to $00000000 address. To interpret the stacktrace I need a non-stripped executable, preferrably compiled with -g option with GCC from MorphOS SDK.

_________________
RastPort

@all
An updated preview can be downloaded here:
http://cshandley.co.uk/temp/PictureAlbum_preview_101009.lha

Changes in this latest release:
- The AROS executable should REALLY work now! Thanks Ball000.
- The MorphOS executable *SHOULD* work... Maybe 3rd time lucky? EDIT: Nope :(
Let me know if there are any problems!
- EXIF thumbnails now work on AROS.

WARNING: Linux hosted AROS is too slow for PictureAlbum, don't bother even trying

Last edited by ChrisH on 11-Oct-2010 at 11:46 PM.

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@ChrisH

Excellent work Chris, it's coming along really well. A couple of suggestions...

Support photoalbum thumbnails, jpg format at least (I have a massive database of these and it would be nice just to copy them into the PictureAlbum cache instead of spending hundreds of hours recreating them).

A quit button on the screen titlebar

A bit more info while loading eg. "picture xxx of xxx" or somthing, as I work with big pics and it takes ages to create the tumbs.

Muiltiselect for copying/moving.

Now the biggie... A dual panel option so images can be moved to other drawers instead of having to move them one drawer at a time in the directory structure and allow cross partition copying/moving.

_________________
OS4 Rocks
X1000 beta tester, Sam440 Flex (733)

Visit the Official OS4 Support Site for more help.

It may be that your sole purpose is to serve as a warning to others.

@Severin
Probably some bugs should be addressed first.

When loading JPEGS from my 14 megapixel camera (4320x3240) the pointer freezes while it's decoding and scaling the image.

I selected menu "File/Create Folder", entered "new" for the name, clicked OK and got a DSI grim reaper. Selecting "Ignore DSI errors" resumed the program with an icon for folder "new" that does nothing when I double-click it.

Using SAM FLEX 800 with OS4.1u2

_________________
X1000 with 2GB memory & OS4.1FE

@ChrisH

Quote:

2. An off-screen thumbnail bitmap is allocated using: AllocBitMap(width, height, depth, BMF_MINPLANES OR $80 /*BMF_HIJACKED*/ OR (10 SHL 24), NIL) ->no friend! Note that the flags are equivalent to BMF_MINPLANES OR BMF_SPECIALFMT OR SHIFT_PIXFMT(PIXFMT_RGB24)

Looking at the cybergraphx/cybergraphics.h header file in the above code you should have "(9 SHL 24)" instead of "(10 SHL 24)" if you want to allocate a bitmap in RGB24 format. If you use "(10 SHL 24)" you are instead allocating a BGR24 bitmap which would explain why you are getting wrong colours (red and blue channels are swapped).

From cybergraphx/cybergraphics.h file:
Quote:

#define PIXFMT_RGB24 (9UL) #define PIXFMT_BGR24 (10UL) #define SHIFT_PIXFMT( fmt ) (((ULONG)(fmt)) << 24UL)

Last edited by salass00 on 01-Jul-2011 at 02:34 PM.
Last edited by salass00 on 01-Jul-2011 at 02:34 PM.
Last edited by salass00 on 01-Jul-2011 at 02:33 PM.

@salass00 Quote:

Looking at the cybergraphx/cybergraphics.h header file in the above code you should have "(9 SHL 24)" instead of "(10 SHL 24)" if you want to allocate a bitmap in RGB24 format. If you use "(10 SHL 24)" you are instead allocating a BGR24 bitmap which would explain why you are getting wrong colours (red and blue channels are swapped).

Damn, you could be right! Although I have a strange feeling someone actually told me to use BGR24 on MorphOS... but my code comments seems to suggest otherwise (since they mention RGB24).

I will try changing that, thanks

Last edited by ChrisH on 02-Jul-2011 at 09:31 AM.

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@Xenic Quote:

Probably some bugs should be addressed first.

Are you using the latest version? This version was reported on www.Amigans.net, but that seems to be down at the moment, however my homepage still lists the most recent version.

Quote:

I selected menu "File/Create Folder", entered "new" for the name, clicked OK and got a DSI grim reaper. Selecting "Ignore DSI errors" resumed the program with an icon for folder "new" that does nothing when I double-click it.

A Crash Log could be helpful, but please email (or PM) it to save filling the thread with several screens of "techno rubbish".

Quote:

When loading JPEGS from my 14 megapixel camera (4320x3240) the pointer freezes while it's decoding and scaling the image.

There is nothing I can do about that, and it might even indicate a problem with your system. I simply tell Datatypes to load the picture. If the mouse pointer stops moving (I don't think this should happen) then it is nothing to do with me. Does the same problem happen if you load the picture using Multiview?

Last edited by ChrisH on 02-Jul-2011 at 09:47 AM.

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@Xenic Quote:

When loading JPEGS from my 14 megapixel camera (4320x3240) the pointer freezes while it's decoding and scaling the image.

It sounds suspiciously like your Sam Flex's harddisk access is using PIO mode rather than DMA. This will cause all disk accesses to be very slow, and to heavily use the CPU.

Can you check whether this is the case or not? (It is a Uboot setting, which has been discussed many times before.)

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...