@MickJT

The space -> underscore issue is xadmaster's fault, and has been fixed months ago in MorphOS 2.5 ( http://www.morphos-team.net/releasenotes-2.5.html )

ups. i was to fast and forgot to deaktivate som debugoutput. a version 2.15
is in the uploaddirs of os4Depot and aminet.

_________________
no RISC, no fun

@Fab

Strange though that it's OK with 2.12 then. The LhA client doesn't seem to be a module that can just be replaced. Looks like it's embedded in xadmaster.library itself?

@aclogic

The description still says 2.12. I notice you've removed the URL from the .readme now.

Edit: Seems to be an OS4Depot anomaly. I'll have someone look at it for you. The .readme does say 2.15. The recent page is currently incorrect though.

Edit2: As Chris_Y says below, it's the header level.

Last edited by MickJT on 03-Jan-2011 at 06:48 PM.
Last edited by MickJT on 03-Jan-2011 at 06:14 PM.
Last edited by MickJT on 03-Jan-2011 at 06:04 PM.
Last edited by MickJT on 03-Jan-2011 at 06:03 PM.
Last edited by MickJT on 03-Jan-2011 at 05:57 PM.
Last edited by MickJT on 03-Jan-2011 at 05:41 PM.
Last edited by MickJT on 03-Jan-2011 at 05:39 PM.
Last edited by MickJT on 03-Jan-2011 at 05:38 PM.

(reposted from news article comments)

@MickJT

It's the header level. 2.14 defaults to header level 1 (older versions defaulted to header level 0).

Archive using:
lha -H0 a test.lha "my file with spaces"

and XAD works fine.

Using -H1 or -H2 you get underscores instead.

I assume if LhA and WinRAR both extract this correctly, that it is an intended feature of header level 1 & 2, and it is xadmaster.library that needs fixing (as already alluded to above)

_________________
"Miracles we do at once, the impossible takes a little longer" - AJS on Hyperion
Avatar is Tabitha by Eric W Schwartz

@Chris_Y

Yeah I agree, xadmaster needs patching.

I've just edited all of my posts where I assumed it was a bug in LhA. That's a lot of edits!

Last edited by MickJT on 03-Jan-2011 at 06:20 PM.
Last edited by MickJT on 03-Jan-2011 at 06:14 PM.
Last edited by MickJT on 03-Jan-2011 at 06:12 PM.

@MickJT

xadmaster is fixed in CVS already:
http://libxad.cvs.sourceforge.net/viewvc/libxad/libxad/portable/clients/LhA.c?r1=1.15&r2=1.16

If I could figure out how to compile it I'd build a new version myself!

(I think it might need autoconf and configure running over portable/ and then makefile.os4 used in portable/amiga)

Last edited by Chris_Y on 03-Jan-2011 at 06:27 PM.

_________________
"Miracles we do at once, the impossible takes a little longer" - AJS on Hyperion
Avatar is Tabitha by Eric W Schwartz

@Chris_Y

Ah, ok, forget my last post in the news thread then.

@Chris_Y

Quote:

It's the header level. 2.14 defaults to header level 1 (older versions defaulted to header level 0).

I didn't know that, thank you (also, thanks to MickJT for investigating the issue).

However, I don't think it's wise to change that default setting, as it breaks all the scripts that assume that the default is -H0. Of course, I'd understand if there's a more important reason for that.

_________________
RETREAM - retro dreams for Amiga, Commodore 64 and PC

@saimo

Quote:

I didn't know that, thank you (also, thanks to MickJT for investigating the issue). However, I don't think it's wise to change that default setting, as it breaks all the scripts that assume that the default is -H0. Of course, I'd understand if there's a more important reason for that.

Agree. Since it has always worked (I assume??) there is no reason to change the *default* just because header level 0 is "hacky" or whatever inside the archive. If it works, it works and noone cares what's on the inside.

Is there really a reason for this change, other than using a prettier chunk of code?

_________________
- Don't get fooled by my avatar, I'm not like that (anymore, mostly... maybe only sometimes)
> Amiga Classic and OS4 developer for OnyxSoft.

@aclogic

Quote:

i was to fast and forgot to deaktivate som debugoutput. a version 2.15is in the uploaddirs of os4Depot and aminet.

Thank you for staying on top of this problem, your effort is much appreciated.

_________________
Hate tends to make you look stupid...

@thread

The xadmaster bug is fixed!

http://www.unsatisfactorysoftware.co.uk/ftp/amiga/xad_lha.lha

This is for OS4 only. The client is set to need v13 of xad, so I don't think I can compile it for 68k (really, somebody should have compiled v13 of xadmaster for 68k by now)

Once a few people have said it's OK, I'll upload it somewhere more permanent.

PS I found another LhA bug in the process - you can't archive a file called "LhA", although it'll be picked up in recursive mode in a subdirectory.

Last edited by Chris_Y on 04-Jan-2011 at 12:24 AM.

_________________
"Miracles we do at once, the impossible takes a little longer" - AJS on Hyperion
Avatar is Tabitha by Eric W Schwartz

@Chris_Y

Using your patch I get a ISI if open an test archive in RAM: created with the new lha

Stack trace:

LhA:LhA_GetInfo()+0xB0C (section 1 @ 0x2b5c)
module LIBS:xadmaster.library at 0x6FD085A8 (section 5 @ 0x9588)
module LIBS:xadmaster.library at 0x6FCFF128 (section 5 @ 0x108)
module sys:utilities/UnArc at 0x6FC42744 (section 5 @ 0x3724)
module sys:utilities/UnArc at 0x6FC44D34 (section 5 @ 0x5D14)
UnArc:_start()+0xC08 (section 1 @ 0xe44)
native kernel module dos.library.kmod+0x0001c210
native kernel module kernel+0x00036290
native kernel module kernel+0x00036310


PPC disassembly:
fffffff8: XXXXXXXX illegal address
fffffffc: XXXXXXXX illegal address
00000000: XXXXXXXX illegal address
00000004: XXXXXXXX illegal address
00000008: XXXXXXXX illegal address


SAM-Flex with update 2

Last edited by broadblues on 04-Jan-2011 at 01:08 AM.

_________________
BroadBlues On Blues BroadBlues On Amiga Walker Broad

@Chris_Y
Quote:

PS I found another LhA bug in the process - you can't archive a file called "LhA", although it'll be picked up in recursive mode in a subdirectory.

Are you sure? This works for me:

RAM Disk:> lha -a -x a "lha.lha" OS4:C/lha

It also works with my Dopus4 "LHA ADD" menu.

I thought you were right the first time I tested it. However, I had renamed another file as "lha" to perform the test and finally realized that AmigaDOS was trying to execute the renamed file instead of the "lha" command in the C: directory. Archiving the lha command itself as "lha.lha" works for me.

Edit: When I try to archive the file named "lha",AmigaDOS tries to execute the file instead of the lha command in my "Commands" directory which is "Assign added" to C:. However, if I move the "lha" command to my "C:" directory then the process works. This looks more like an AmigaDOS quirk and not an lha bug to me.

Last edited by Xenic on 04-Jan-2011 at 04:23 AM.

_________________
X1000 with 2GB memory & OS4.1FE

@Xenic

That's not an AmigaDOS bug, it's a feature

What's happening is that the current directory is searched first when one tries to run a program; that lets you do things like run a newer version of lha while you're testing it without having to clobber the one in C:

Last edited by CodeSmith on 04-Jan-2011 at 07:10 AM.

@Chris_Y
Thanks for finding out that -H0 for LhA fixes UnArc/etc. I have added it to my LhA script.

@aclogic
LhA should be 'fixed' to use -H0 by default again, or a lot of people will have problems UnArcing stuff from Aminet & OS4Depot. Only once a XAD fix is widespread (say after a couple of OS4 updates & maybe an OS3 fix as well) would I even consider changing this default again.

Last edited by ChrisH on 04-Jan-2011 at 09:32 AM.

_________________
Author of the PortablE programming language.
It is pitch black. You are likely to be eaten by a grue...

@broadblues

I'll take a look, thanks. Can you email me the archive as the test I created worked?

_________________
"Miracles we do at once, the impossible takes a little longer" - AJS on Hyperion
Avatar is Tabitha by Eric W Schwartz

@Chris_Y

I can't get the crash to occur again today, very odd as it happened after two reboots in a row yesterday.

The archive that caused the crash was created with

lha -r a a.lha ""

run from ram:

_________________
BroadBlues On Blues BroadBlues On Amiga Walker Broad

@ChrisH
Quote:

LhA should be 'fixed' to use -H0 by default again, or a lot of people will have problems UnArcing stuff from Aminet & OS4Depot. Only once a XAD fix is widespread (say after a couple of OS4 updates & maybe an OS3 fix as well) would I even consider changing this default again.

Not so fast Chris. This problem is a little of a conundrum. The switch to -H1 as the default appears to have fixed the conversion of "odd" seconds to "even" seconds. Changing the time of the file could potentially create problems with Installers and Backup programs that rely on file datestamps. On the other hand, changing the filename (substituting underscore for spaces) could be even more problematic. This is a case where we need to choose our poison; altered filenames or altered datestamps. I think we should get some more opinions before changing anything.

EDIT: Changing the datestamp by 1 second does seem to be less of a problem and makes current Amiga "lha" consistant with previous versions.

Last edited by Xenic on 04-Jan-2011 at 03:48 PM.

_________________
X1000 with 2GB memory & OS4.1FE

@broadblues
A quick Hex read of lha indicates that it might use T: for temporary storage while it's archiving everything in RAM:. I would imagine that writing to a directory at the same time that it is being archived could create some internal conflict in lha. It probably shouldn't happen but I can see how it could. I suppose that archiving a directory at the same time as another program is altering/adding/deleting files in that directory might pose a problem too. Maybe you could try a script that repeatedly creates an archive (using the same command as you listed) & deletes it to see if you can reproduce the problem.

_________________
X1000 with 2GB memory & OS4.1FE

@Xenic

Quote:

EDIT: Changing the datestamp by 1 second does seem to be less of a problem and makes current Amiga "lha" consistant with previous versions.

This.

Last edited by saimo on 04-Jan-2011 at 05:36 PM.

_________________
RETREAM - retro dreams for Amiga, Commodore 64 and PC