In the wait for the bounty to be validated/unvalidated by Power2People.org, depending on the feedback concerning the review requested by them in another thread...
Here is a new subject/thread that will be dedicaced to the bug fix of the AmiDARK Engine in its current Alpha/Beta Open Sourrce.

Don't forget that the source code is currently available only for "review" purposes.
When Power2People.org will have validated the bounty, the paiement of the bounty will makes the MPL become really effective.

So, now, here are the details :

I have took informations about bugs in a file on my HD.
I will put here only what is already fixed and what will not be "changed" for DBPro/DarkGDK compatibility :

Global :
**Fixed** Remove Path in cbp projects (new files from zzd10h)
**Fixed** Remove unused/old files

Basic2D :
**Fixed** : DERGB, DERGBR, DERGBG, DERGBB set as #define.
(functions keeps for DBPro/DarkGDK compatibility)

Bitmap Module :
DELoadBitmap : 0 to 9 -> 0 to 8 Fixed

Camera3D :
**Fixed** CameraConstructor -> All inits are now ok.
**Fixed** DEClearCameraView(Ex/Ex2)
**Fixed** DEMakeCamera -> Reset forgotten data.
**Fixed** DESetCameraRange(Ex) -> Float data required cast as GLdouble for GL command needs.
**Fixed** DEMakeCamera -> Reset BackR BackG BackB & RotMode + Fixed deGetDisplayHeight() = 0 risk.
**Fixed** CurrentCamera usage : Add check everywhere to be sure that if data is trashed, it will not crash the system setting data on wrong memory zone.
**Fixed** Changed all Camera.Exist[ CameraID ] with use of DECameraExist( CameraID ) function that do more checking to not access unwanted memory zone.
**Fixed** Added DebugMessage for all camera functions.

Maths3D :
**Fixed** FindXAngle & FindYAngle division by 0 issue.

Last Edit : 2015.02.19
Will now check others bugs reported by Daytona675x :

2015.02.19 Last changes from 2015.01.25 up to today :

Core (partially) :
1. AdvFctList : Not a bug, only an improvement as things work perfectly.
2. ListFuctionToRender : Just a printf that will be removed when the ErrorHandler will be done. Not really a bug as the function work perfectly and display an error message when needed.
3. DESqr : Bug.
4. DEWrapValue : Bug. Fixed.
5. DEWrapValueEx : Not a bug, just a function for compatibility with DarkGDK (deWrapValueEx)
6. deMaths_Functions.c : Inline function. The current ones work no ? So, if not precision about 1 function with a unstable or non working behaviour. It’s not a bug.
7. DEGetDate : Yes, the function was commented because *not working*. It already is in my personal bug list to fix.
8. DEGetTime : Same comment than for the previous function.
9. DEFillMemory : Function work. Not a bug -> Improvements.
10. DESuspendForKey : Function work. Not a bug -> Improvements
11. DESuspendForMouse : Bug.
12. DEWaitMouse : Bug
13. DECl : Bug
14. DEInputS : Function existe under DarkGDK. Compatibility. Then NOT a bug.
15. InputInteger (internal function) : Bug
16. InputFloat (internal function) : Bug
17. DEDrawToFront/ToBack & DESpritesFirst/Last : just debug output. The function work and make a debug output if needed. Not a bug.
18. DESyncON/On DESynfOFF/Off : Not a bug, compatibility with DarkGDK.

Amount of Reports : 18
Bug Amount : 9
Bug Fixed : 1
Improvements : 3
Others (not bug at all ) : 6
Core amount of User functions : 81
Core Amount of internal functions : 20
Total : 101 functions.
9 bugs = 8.9% nok / 90.1% ok


Text :
1. TXT_Constructor : Bug. Fixed
2. TXT_Destructor : Bug. Fixed
3. DEAsc = Function is working. No bug -> Improvement.
4. DELeft : Bug. Fixed
5. DELen : Function is working. No bug -> Improvement
6. DELower : Bug. Fixed
7. DEMidEx : Bug. Fixed
8. DELeft/MidEx : Under DarkGDK, if you send an empty string or null… It will simply return the same result. No bug.
9. DEMid : Bug. Fixed
10. DERight : The Doc will explain that ALL strings send to AmiDARK Engine function should be created using the LCreateString and ALL the strings received from the engine should be deleted using LDeleteString ( or LCreateDeleteString that can do both work depending on which arguments the user pass to the function ). No bug.
Length bug. Fixed
11. DEUpper : Bug. Fixed
12. DESpace : Bug. Fixed
13. DEVal : Bug. Fixed
14. DEFlip : Bug. Fixed + Added pointer/size checkings.
15. DEBin : Bug. Fixed
16. DEHex : Bug. Fixed
17. DEValF : No bug-> Improvement
18. DEChr : No Bug. I am not responsible of what user will do with string memory allocation. Reduced LCreateString to 2 bytes but, it will change nothing to what user can do to memory located after these 2 bytes.
19. DEAppend : Bug. Fixed
20. DETextStyle : No bug as function work. -> Improvement.
21. DECompareCase : Bug. Fixed
22. DEReverse : Not yet created. Now done. This function is slightly different from DEFlip as it directly reverse the string entered as parameter. It does return nothing.
23. DEFindSubString : Bug. Fixed
24. DEFindFirstChar : Bug. Fixed
25. DEFindLastChar : Bug. Fixed

Amount of Reports : 25
Bug Amount : 18
Bug Fixed : 18
Improvements : 4
Others (not bug at all ) : 3
Text amount of User functions : 46
Text Amount of internal functions : 3
Total : 49 functions.
18 bugs = 36.7% nok / 63.3% ok

Regards,
AmiDARK

Last edited by AmiDARK on 19-Feb-2015 at 10:37 AM.
Last edited by AmiDARK on 19-Feb-2015 at 10:21 AM.
Last edited by AmiDARK on 19-Feb-2015 at 09:19 AM.
Last edited by AmiDARK on 25-Jan-2015 at 12:32 AM.
Last edited by AmiDARK on 24-Jan-2015 at 11:10 PM.
Last edited by AmiDARK on 21-Jan-2015 at 11:25 PM.
Last edited by AmiDARK on 21-Jan-2015 at 11:02 PM.
Last edited by AmiDARK on 21-Jan-2015 at 10:38 PM.
Last edited by AmiDARK on 21-Jan-2015 at 10:27 PM.
Last edited by AmiDARK on 21-Jan-2015 at 10:14 PM.
Last edited by AmiDARK on 19-Jan-2015 at 10:24 AM.
Last edited by AmiDARK on 17-Jan-2015 at 12:24 PM.
Last edited by AmiDARK on 17-Jan-2015 at 08:10 AM.
Last edited by AmiDARK on 16-Jan-2015 at 11:37 PM.
Last edited by AmiDARK on 16-Jan-2015 at 11:30 PM.
Last edited by AmiDARK on 16-Jan-2015 at 11:05 PM.
Last edited by AmiDARK on 16-Jan-2015 at 12:14 AM.
Last edited by AmiDARK on 14-Jan-2015 at 08:46 PM.

The 2nd post of this thread will show the progress concerning bug fixing/improvements. It will be updated each time new progress are done.

Last Changes : 2015.01.16 23:37 *Update done*

Global :
- Removed few *unused* files that were always in the CODE.

Camera Module :
- Camera Near/Far/FOV/Aspect now initialized as GLdouble
- Constructor now initialize Camera.Aspect[] correctly for all the cameras available.
- DESetCameraRange & DESetCameraRangeEx fixed : Request Float, save casted as GLDouble.
- DESetCameraFOV & DESetCameraFovEx adapted to the changes for FOV variable : Save casted as GLDouble
- DEMakeCamera now reinitialise correctly all 20 variables of a freshly created camera.
- DEClearCameraView, DEClearCameraViewEx & DEClearCameraViewEx2 now fixed to cast integer value from range 0-255 to float one 0.0f-1.0f

SDK :
Updated the Camera definition file to handle changes in the DESetCameraRange function.

Last edited by AmiDARK on 16-Jan-2015 at 11:04 PM.

@AmiDARK

I replugged my 9250 to test your GDK and to test the latest binary that you sent me :

-a 640x480 screenmode is REALLY required
-my latest BoingBall binary freezes my system
-my latest BoingBall binary compiled with your latest libAmiDark.a freezes my system

BUT
-your latest BoingBall binary works !




Maybe that since 0.9 that I tested a dependency changes makes this crash when I compile a AmiDark samples.

Therefore, you should remake a complete installable package.

Last edited by zzd10h on 17-Jan-2015 at 09:24 AM.

_________________
http://apps.amistore.net/zTools

@zzd10h :
Hello and thank you for this important report as it show, like you mention it, that there are chances that it's something external to the library itself that caused your crash.

I will prepare soonly a new release with all needed files (when some more bugs will be fixed) with all needed library. More to this, do you use version 53.20 or 53.24 of the Hyperion SDK ?

Concerning the Display, I'm not sure to understand what you wanted to report as the demonstration is already using 640x480 but in windows mode
Check this line
(16) DESetDisplayMode( 640, 480, 32 ); // set display mode to 640x480 using 32bits depth )
If what you want is to turn it to "full screen mode", just remove the "//" comments at the beginning of this line :
(17) // DESetWindowOff(); // Jump in fullscreen mode.
It will makes the demonstration run in 640x480x32bits full screen mode.
If what you said is that you need a 640x480 screen mode in monitors prefs, Thank you to report this functionality... Then if someone know how check if the monitor contain a definition of a precise resolution, I can add a checking for this.

Regards,
AmiDARK

Last edited by AmiDARK on 17-Jan-2015 at 10:37 AM.

@AmiDARK

I just mean that WITHOUT a 640x480 screenmode in Prefs/Screenmodes the window doesnt' open.

The 640x480 screenmodes must to be defined in the screenmodes no need to activate it for the Workbench screen (my screen is 1920x1080).

Fixed CBP with APPDIR:CodeBench instead of your hard-coded path

http://zzd10h.amiga-ng.org/AmiDark/AmiDark_CBP.lha

_________________
http://apps.amistore.net/zTools

@AmiDARK
Quote:

With the fact that I AM and I REMAIN the LEAD DEVELOPER of this project as it was decided with the community before starting the BOUNTY and is a non debatable/disputable requirement, I want to remind some important informations concerning the project and how I will continue to LEAD it

Could you please link and quote the phrases saying so on the bounty's page?
Because, as far as I can see, it says the following:

Quote:

... for free use under the MPL licence, the Mozilla Public Licence

and

Quote:

Optional:If this project is successfully funded (by raising a minimum of 1500 Euro), and as long as the resulting ports stay true to the original version of the AmiDARK Engine in terms of user experience and command sets, Frédéric Cordier plans to share all source code that he will develop himself for future versions of the AmiDARK Engine for free

I don't see where it says you lead anything, please help me.
As far as I can see - and what is to be expected:
If you get the money you have to make sure everybody who wants can work on the source - without you censoring or whatever.
Before you get money you own it, of course, and can do what you want to get it into a useable state or not, sure.

But after you got paid the only thing the bounty says about you is that if you think that nobody alters it to a degree you don't like or so you plan to continue to also work on it in public (thanks to the word "plan" it's a pretty empty phrase of course).

Where is that "leader" thingy?

Sorry to get a bit off-topic regarding the thread's title, but since you posted it yourself at the beginning of this thread I think that question is acceptable here.

Last edited by Daytona675x on 17-Jan-2015 at 11:10 AM.

_________________
AmigaOS 4.1 FE (sam460ex Radeon 9200 / RadeonHD), MorphOS 3.8 (PowerMac G4 733MHz Radeon 9000), AROS (x86), A1200 (060 80MHz Indivision MK2), A500, A600, CDTV
Wings Remastered Development Diary

@Daytona675x
Simply read this, the full story and you'll understand that it was a desire of the Amiga Community when the bounty idea was submitten as a solution...
http://www.amigans.net/modules/xforum/viewtopic.php?start=0&topic_id=6519&viewmode=&order=ASC&type=&mode=0
More to this, as some users pointed it to you, their donation was more a "charity" donation to support me and this project even if it's released as MPL.
Of course, you're free to post any changes, and if you want to be an additional developer, I will be happy to add you in the list just like I added BSZili that already commit changes...

Did your *hidden* project, with your "hard" message (more than review), to try to keep the direction of the project by trying to kill what the amiga community think about me?

One thing important, is that, with the engine structure, my knowledge in DarkBASIC Professional and DarkGDK, even if I'm not "as pro as you" at C coding, makes the fact that until someone keep enough time to discuss with me and learn DarkBASIC Professional/ DarkGDK, It's the best solution for the project, to makes me LEAD the development (and be sure it will continue in the direction it was initially planed to go.

Regards,
AmiDARK

Last edited by AmiDARK on 17-Jan-2015 at 11:22 AM.
Last edited by AmiDARK on 17-Jan-2015 at 11:21 AM.
Last edited by AmiDARK on 17-Jan-2015 at 11:16 AM.

@AmiDARK
When I donate for a bounty I certainly don't expect that the bounty-creater comes up with additional crucial information afterwards and tells me that I had to check some forum anywhere on the web beforehand to get to know what I am donating to...

No, I expect that I get what it says on that page (and as we all know I didn't even get that, but that's a different story).
And there it says MPL, open-source. Period. It doesn't say "Freddy is the leader and he decides what to do with that stuff, even if it officially gets open-sourced"...

There is a word for this: fraud.
But actually, regarding your initial and ongoing behaviour, I don't wonder.

Last edited by Daytona675x on 17-Jan-2015 at 11:24 AM.

_________________
AmigaOS 4.1 FE (sam460ex Radeon 9200 / RadeonHD), MorphOS 3.8 (PowerMac G4 733MHz Radeon 9000), AROS (x86), A1200 (060 80MHz Indivision MK2), A500, A600, CDTV
Wings Remastered Development Diary

@Daytona675x
You can think what you want, I just remind you something :

1. From what you said .. .Apparently, you didn't donate to this project.
2. It was a desire from (mains of) the donators of the project that I continue to work on it and keep some "control" on the direction the project go.
3. The MPL Licence allow some things, I will prevent no one from developing in the respect of the MPL licence and add it as developer if he agree 1 thing : The AmiDARK Engine was developed to create something similar to DarkGDK (and then later DarkBASIC Professional).
No fraud there.

@AmiDARK
Quote:

1. From what you said .. .Apparently, you didn't donate to this project.

That doesn't matter.

Quote:

2. It was a desire from (mains of) the donators of the project that I continue to work on it and keep some "control" on the direction the project go.

(Mains of) alone already says anything.
It remains a fact that there's nothing like that on your bounty description.

Quote:

3. The MPL Licence allow some things, I will prevent no one from developing in the respect of the MPL licence and add it as developer if he agree 1 thing : The AmiDARK Engine was developed to create something similar to DarkGDK (and then later DarkBASIC Professional).

No, you wont? But you already said so above (you are the leader and decide whom to add and what to add etc.)

But this is actually not debatable, since in your bounty's decription it clearly says "open-source" with the only additional thing regarding you and your activity / role that you will probably not contribute anything if you think that the original spirit or whatever is not yours.

So, again: if you suddenly change the rules this is fraud. Because you don't sell what was advertised.

_________________
AmigaOS 4.1 FE (sam460ex Radeon 9200 / RadeonHD), MorphOS 3.8 (PowerMac G4 733MHz Radeon 9000), AROS (x86), A1200 (060 80MHz Indivision MK2), A500, A600, CDTV
Wings Remastered Development Diary

@Daytona675x

Maybe then the MPL Licence should calm you a bit :
http://en.wikipedia.org/wiki/Mozilla_Public_License

Quote:

The Mozilla Public License (MPL) is a free, open source, and detailed software license developed and maintained by the Mozilla Foundation. It is characterized as a hybridization of the modified BSD license and GNU General Public License (GPL) that seeks to balance the concerns of proprietary and open source developers.[7]

Quote:

The MPL has been approved as both a free software license by the Free Software Foundation[3] and an open-source software license by the Open Source Initiative.[4] The MPL allows covered source code to be mixed with other files under a different, even proprietary license. However, code files licensed under the MPL must remain under the MPL and freely available in source form.[6] This makes the MPL a compromise between the MIT or BSD licenses, which permit all derived works to be relicensed as proprietary, and the GPL, which requires the whole of a derived work, even new components, to remain under the GPL. By allowing proprietary modules in derived projects while requiring core files to remain open source, the MPL is designed to motivate both businesses and the open-source community to help develop core software.[15]

If fact, you can create your own branch of the AmiDARK Engine as a DERIVED PROJECT as you continue to release it as MPL licence, and I can continue to develop and LEAD my branch of the AmiDARK Engine as I continue to release it as MPL licence. as MPL is a good mix between OPEN SOURCE and PROPRIETARY developers. For this, no need for someone that develop a DERIVED PROJECT to be a coder of the original MPL Open Source one ... He can create it's own MPL Open Source Project based on the AmiDARK Engine MPL releases.
You understand now ?

Last edited by AmiDARK on 17-Jan-2015 at 11:44 AM.
Last edited by AmiDARK on 17-Jan-2015 at 11:43 AM.
Last edited by AmiDARK on 17-Jan-2015 at 11:40 AM.

Daytona,

Don't take it too serious. Of course mpl rules are applied. When he speaks about leader he just tries to satisfy the donors and of course he will be the main dev anyway because it just didn't got the attention yet.

At all:
If you didn't donate I would have bought it with the knowledge to pay further development...
Open source is bad hmmkay
So now since you decided the bounty was fine and is now fulfilled , please contact p2p about that.

_________________
AROS Broadway - AEROS - Aminux - AmiCloud - indieGO! Appstore - AmiWallet - VAN lossless video codec - AMC Amiga media Center -KrypUnite - LibertyNet - MinX - amigaNX

@AmiDARK
Quote:

If fact, you can create your own branch of the AmiDARK Engine as a DERIVED PROJECT as you continue to release it as MPL licence, and I can continue to develop and LEAD my branch of the AmiDARK Engine as I continue to release it as MPL licence

Well, that is great - but it still doesn't explain your "undebatale leadership, the man who decides what gets fixed and what not, etc." (your words, not mine).
So, are you just talking about your private branch? Of course, you can do with that one what you want.
Or do you talk about the official open-sourced main branch? Well, you just sold that (if it got accepted, have no idea) to the world, to freely modify it. Without a dictator.

@phoenixkonsole
Quote:

Don't take it too serious.

Yes, probably you're right with that one. Besides that I sometimes have the feeling to talk to a wall anyway. Well, after all: it's the funeral of those who donated, not mine

_________________
AmigaOS 4.1 FE (sam460ex Radeon 9200 / RadeonHD), MorphOS 3.8 (PowerMac G4 733MHz Radeon 9000), AROS (x86), A1200 (060 80MHz Indivision MK2), A500, A600, CDTV
Wings Remastered Development Diary

@Daytona675x
This sentence was just for you, to makes you react to show you in a more clear way what you did on the other post. You tried to "dictate" your though on the project and it is not acceptable too. Maybe with that you understand that your way of acting in the other thread is unacceptable... And to show you that even with your *personnal* attack against myself in several of your purpose on the other thread, I will not leave the project! As your way of acting in the other post really makes feel that it was one of your main *non official* goals to rule the development of the project...

As I know ... no one of the contributor is against the fact that I continue to "lead" the project to be sure it will keep the direction it was devoted to (except you if you donated but apparently you didn't... or your don't assume your speeches on your legal name your purposes by not saying you donate)...

This sentence will be *completed* as it was only to show you my determination to not let the projects fall as you tried to convince peoples I cannot be good enough for it!.

Here is the 3. information as I wanted your react to put it :
3. When Power2People.org will have validated the bounty, the paiement of the bounty will makes the MPL become really effective and then rules will not be the same ... They will be fully the MPL Licence rules

Don't forget I an NOT YET Paid for the release under MPL Licence, so officially, this is only for "validating" the Bounty that is NOT YET validated by Power2People. When they will validate the paiement for the open source ... It will fully become MPL.

Thank you for going exactly where I wanted you to go Daytona. As you stated, the only important things are the ones available in the BOUNTY and in the full MPL Licence :
https://www.mozilla.org/MPL/2.0/
But ... When the paiement will be done.

@Zzd10h : Ok. Thank you for these informations.

Regards,
AmiDARK

Last edited by AmiDARK on 17-Jan-2015 at 12:31 PM.
Last edited by AmiDARK on 17-Jan-2015 at 12:26 PM.
Last edited by AmiDARK on 17-Jan-2015 at 12:26 PM.

@AmiDark

It could have been explained without those words in capital.

"I would like to maintain my own branch of this engine, so anyone who wants to contribute is welcome, I'll look at comments/bugs reported and will take the decisions I do think are the best". Of course, as any opensourced project, it is allowed to create other branches of this engine, so we can expriment different technical solutions".

Reviewers may have not given sone money, anyway, thay have given a lot of time to review, and that is much more important than money, it's time!

@AmiDARK
Quote:

Thank you for going exactly where I wanted you to go Daytona.

Oh man, you are priceless, really

I know that it won't help but nevertheless:
what you write here, regarding your leadership etc. etc. is not what you tell / sell the people on the bounty's page. That's a fact.

And even if you said different in some forum it remains a fact. What you say in some forum is of no interest to the bounty's description (unless you had exlicitely linked to it from there, which, of course, you did not). Another fact.
To make it more clear to you: if I buy a car I expect that what is written inside the final contract is what it's all about. It doesn't matter what and if in some car-magazine there's different information.
Got it?

Besides that we got the fact that you did not mention that even your demos are unstable etc. (instead you continued to falsely claim the contrary).
Then we also got the fact that you also sugarcoat the documentation's state.
Facts. Proven, multiple times.

Plus we got your general attitude (telling people that proven stability issues would not exist, pointing to others while actually starting with insults, etc. etc.)

Well, if you take all that and sum it up, the result is pretty obvious:
mis-selling, fraud. No doubt on that. And it gets worse with every post of yours.

Anyway, in the meantime I'll still continue my reviews. Why? Because it's probably helpful for the community.

_________________
AmigaOS 4.1 FE (sam460ex Radeon 9200 / RadeonHD), MorphOS 3.8 (PowerMac G4 733MHz Radeon 9000), AROS (x86), A1200 (060 80MHz Indivision MK2), A500, A600, CDTV
Wings Remastered Development Diary

@phoenixkonsole

Quote:

because it just didn't got the attention yet.

i think thanks to daytona it actually got all attention it could, and thanks to controversy around it actually even more than that. if none had reviewed the code (and apparently except him and bszili none did) the bounty would be quietly closed, paid and forgotten. which is whats going to happen in due time anyway, it only takes a little longer now. i wonder where do you expect the additional attention to come from?

Quote:

Open source is bad

a little strange statement from someone who bases his contribution on aros, which is open source. i understand, you realize that there are both sides to the medal, but imho in the community, as it became to be, there is no better choices left. there is simply no critical mass, no current any more how ever you wouldnt twist it. open source is in this respect a lesser evil, if you will.

@DC_Edge
What I wanted to tell is that OPEN SOURCE mean I AM NO MORE THE OWNER OF THE SOURCE CODE.
As Daytona said, I cannot claim I LEAD ALONE the project when the paiement will be done and Licence MPL Apply.
That why, all bug reports, will be fixed on the MAIN BRANCH but, if people want to contribute in a way that don't go in the original direction (DarkBASIC Pro / DarkGDK Clone), then I will have no other solution than maintain my own branch of the engine.

Review are always good on the fact that they bring solutions.. But it does not permit reviewer to have a pejorative tone ...

@Daytona :
Quote:

Oh man, you are priceless, really

I know .. I hate act this way, but I adapt to people I have in front of me ;)

Regards,
AmiDARK

@DC_Edge

Quote:

Reviewers may have not given sone money, anyway, thay have given a lot of time to review, and that is much more important than money, it's time!

i think in this case there may be something that may be more worth than both, and exceptionally rare around here, namely expertise.

what concerns the subject as it became i think it is misunderstanding on part of bad wording and capitalising (because if amidark is not going to develop and fix the engine further, who will? as far i can remember, this was his offer, in prospect of no interest of any other developer i was aware of).

Last edited by wawa on 17-Jan-2015 at 01:40 PM.

@AmiDARK
Quote:

I know .. I hate act this way, but I adapt to people I have in front of me ;)

If you'd really do that then we would have working code by now and a bounty fulfilled without false promises - and I could maybe take you serious

_________________
AmigaOS 4.1 FE (sam460ex Radeon 9200 / RadeonHD), MorphOS 3.8 (PowerMac G4 733MHz Radeon 9000), AROS (x86), A1200 (060 80MHz Indivision MK2), A500, A600, CDTV
Wings Remastered Development Diary