Hi,

I was hoping someone may have some Python experience here on AW or elsewhere. I have also posted the question on the dedicated forum, but perhaps someone here can help me solve this problem: and so I'll paste in the same error message encountered.

http://www.flickr.com/photos/61283734@N03/5793026249/ - Error message shown here

----

I am trying to read artwork from an itunes mp4a file and came across an example on the web that lead me to Mutagen. Mutagen built just fine with no errors and I a proceeded to run the python example script given and tweaked it to a given m4a I have stuck on a USB stick.

The Script:
from mutagen import File
file = File('FLASH DRIVE:CD Pool Radio-April 2010/10 Some People.m4a') # mutagen can automatically detect format and type of tags
artwork = file.tags['APIC:'].data # access APIC frame and grab the image
with open('image.jpg', 'wb') as img:
img.write(artwork) # write artwork to new image

Error Message:
Downloads:mutagen-1.20/getartwork.py:5: Warning: 'with' will become a
reserved keyword in Python 2.6
  File "Downloads:mutagen-1.20/getartwork.py", line 5
    with open('image.jpg', 'wb') as img:
            ^
SyntaxError: invalid syntax

Questions:
What does this mean!
Also what does this script do in fact - does it write image.jpg to
disk or something?

-----

Hope someone can help with some words of wisdom.

Last edited by djrikki on 03-Jun-2011 at 10:07 PM.
Last edited by djrikki on 03-Jun-2011 at 10:06 PM.

_________________

@djrikki

I play in PyGame on Amiga and Python is a stickler for indention. Try indenting line six a couple of spaces ? Is this your script or from where?

_________________

@Snuffy

I've got passed the indentation problem, now I have a new error:

Traceback (most recent call last):
File "Downloads:mutagen-1.20/getartwork.py", line 5, in
artwork = file.tags['APIC:'].data # access APIC frame and grab the image
TypeError: 'NoneType' object is unsubscriptable

Original link is here: http://stackoverflow.com/questions/6171565/how-do-i-read-album-artwork-using-python

I've updated the script to:

from __future__ import with_statement # this first line means it can now use the 'with' command
from mutagen import File

file = File('WORK:Home Directory/User Files/Music/03 Common People.m4a') # mutagen can automatically detect format and type of tags
artwork = file.tags['APIC:'].data # access APIC frame and grab the image
with open('image.jpg', 'wb') as img:
img.write(artwork) # write artwork to new image

I am pretty sure these m4as have album artwork because they appear in MacOS X Finder... although there is strangely an Album Artwork folder in iTunes/Music/iTunes Media...

Last edited by djrikki on 03-Jun-2011 at 11:39 PM.
Last edited by djrikki on 03-Jun-2011 at 11:35 PM.
Last edited by djrikki on 03-Jun-2011 at 11:34 PM.

_________________

@snuffy

Okay I think why it is failing is the APIC tag is empty. It appears iTunes doesn't by default embed artwork into the files... >.<

So I've downloaded this great applescript which will go through my entire 9000+ songs and embed images lol

http://dougscripts.com/itunes/scripts/download.php?sc=embedart

_________________

@Snuffy

Success!

http://www.flickr.com/photos/61283734@N03/5795379692/

_________________

@djrikki

Quote:

artwork = file.tags['APIC:'].data # access APIC frame and grab the image

I don't know what type .tags has, but I assume it's a subclass of dictionary. Then, you should modify your code to either return default value by using .get method or handle an exception.

>>> postamiga = {'OS4':'AmigaOne','AROS':'Everything','MorphOS':{'Mac','Efika','Pegasos'}}
>>> postamiga['OS7']
Traceback (most recent call last):
File "", line 1, in
KeyError: 'OS7'
>>> postamiga.get('OS7',None)
>>> print postamiga.get('OS7',None)
None
>>> try:
... print postamiga['OS7']
... except KeyError:
... print "I HAS FAILED"
...
I HAS FAILED

_________________
OpenWindows Initiative. Port PS3 hardware to bananas. For free. Join today and receive expired $50 cupon from AI!

@opi

I don't want to get too deep in python, but how I handle if an audio file does not contain an APIC is simplistic - if image.jpg is not found then the running python clearly couldn't find an attached picture in the audio file.

@ All

Atm I am using Mplayer to return the Duration of an audio file as this isn't (generally) found in the ID3 Tags. I had hoped Hollywood would support mp3s, but the ones I am throwing at it are identified as 'Unknown'...


......is there an alternative command line proggy someone can suggest to return the duration of an mp3/m4a? Must be quick, mplayer always takes 3-4 seconds to even load.

_________________

@djrikki

investigate mpega it has options to display file info, can't remeber if it;ll do durartion or not, but it'll certainly load faster than mplayer.

It's on aminet.

However it's a 68k executable.

There is a PPC replacement for mpega.library though, if hollywood allows acccess to system libraries, then you might be able to use that from within your app.

Or maybe consider writing a small helper program using mpega.library, could be your introduction to programming in C...

Last edited by broadblues on 04-Jun-2011 at 06:15 PM.
Last edited by broadblues on 04-Jun-2011 at 06:15 PM.

_________________
BroadBlues On Blues BroadBlues On Amiga Walker Broad

@djrikki

Re: Python -> Mutagen

Success!
Glad to hear! Opi brought the next idea...data and None in retrievals.

@opi
... you should modify your code to either return default value by using .get method or handle an exception...
Good note! When retrieving data, it's good to know you caught something or nothing!

_________________

@Snuffy

Yeah making some headway.

Looking into adding an iTunes player into Jack, by that I mean, if you have a PC or Mac on the network grab the itunes music library.xml across the network and parse through the data.

Atm I have no idea about sound playback, but that will probably come from mplayer.

Just early stages atm, might not be very effective, definitely worth a try though!

I have thus far made a script that will go through args sent to it (in this case paths to mp3s) and from each arg scan it for album artwork and save it locally to disk.

I am probably an exception to the rule cause I have so much music, cos it currently takes Jack about 45 seconds just to parse through a 14mb XML file containing data on nearly 10000 tracks even before I reach the python script.

Some initial questions:

1) Is there a maximum string length I can pass through on the command line?

eg. whatever.exe "fullpathname.mp3" "fullpathname2.mp3" "fullpathname3.mp3" .... etc ... etc

2) I am having trouble at the moment with quotation marks appearing in filenames, eg. 12" Club Mix, 7" Radio Edit.. I don't know how to a) format that correctly for the command line and b) for the python script itself.

Last edited by djrikki on 05-Jun-2011 at 03:19 AM.
Last edited by djrikki on 05-Jun-2011 at 03:18 AM.
Last edited by djrikki on 05-Jun-2011 at 03:17 AM.
Last edited by djrikki on 05-Jun-2011 at 03:16 AM.

_________________

@djrikki

You know that comment I made about "Eval" and "*" on one of your other threads?

This is where it comes in, to quote a '"' in a double quated string do

"this string has a *" in it"

eg

4.AmigaOS4:> echo "this string has a *"  in it"
this string has a "  in it
4.AmigaOS4:> 

_________________
BroadBlues On Blues BroadBlues On Amiga Walker Broad

@broadblues

So asterisk followed by a double quotation mark... thanks!

_________________

@broadblues

Okay so I have that in place now, but it appears now on closer expection that it wasn't a double quotation mark, but two single quotation marks next to each other! I think single quotation marks are accepted as normal in Amiga filename correct?

(See Twilight Zone)

But python doesn't appear to like it... notice at the end - two single quotation marks - so um not sure what to do - play around I guess until it is accepted.

"SMBFS5:itunes/iTunes Media/Music/2 Unlimited/The Complete History/04 Faces [Radio Edit].mp3" "SMBFS5:itunes/iTunes Media/Music/2 Unlimited/The Complete History/05 Twilight Zone [7'' Vocal].mp3" "SMBFS5:itunes/iTunes Media/Music/2 Unlimited/The Complete History/06 Maximum Overdrive.mp3" "SMBFS5:itunes/iTunes Media/Music/2 Unlimited/The Complete History/08 Get Ready For This [Radio Edit].mp3" "SMBFS5:itunes/iTunes Media/Music/2 Unlimited/The Complete History/07 Let The Beat Control Your Body [Airplay Edit].mp3"
Traceback (most recent call last):
File "python:scripts/jack_getalbumartwork.py", line 10, in
file = File(filename)
File "PYTHON:Lib/site-packages/mutagen/__init__.py", line 203, in File
fileobj = file(filename, "rb")
IOError: [Errno 20] Not a directory: ''


OFFTOPIC: And yes I have their whole album

Last edited by djrikki on 05-Jun-2011 at 12:43 PM.
Last edited by djrikki on 05-Jun-2011 at 12:42 PM.

_________________