When talking about diagonal lines. Im no tech guy but i use the afxgroup version from dopus.
If i use these lines then i get diagonal lines on some youtube clips.

MPlayer *>NIL: -mc 0 -framedrop {f}

If i use this line i dont get the diagonal lines

MPlayer *>NIL: -mc 0 -framedrop -vo sdl {f}

If its of some help

@Kicko

That just means you have overlay working, and mplayer by default uses it. Video output sdl does not use it, and will be a lot slower. Unless the video is of a tiny resolution, so that it doesn't really matter.

_________________
: AmigaOneXE (unmod.) 750FX/512 MB +stuff & AmigaOS 4.(0|1)
: A1200/68060&96MB/SCSI/EM1200-Voodoo3 & OS 3.5
: A500/1MB
: Pegasos (ff) 512 MB & MorphOS
Praise seitan.

@Kicko

Its because in second case you use sdl_driver as output for video (which do autoalignment by itself). I.e. when you do "-vo ....." it mean that you choice some driver.For example for overlay driver i use now: mplayer -vo p96_pip.

In the first case you use default driver of old mplayer, which are also p96_overlay, without fixed alignment. We loose with deniill one evening to try to fix autoalignment in the p96 driver , without too much luck (by some reassons p96 driver a bit messy:( ) so we choice to use hardcore fix from Varhall, which for end-users mean nothing, as it will just works as should, and maybe later we will fix it in the driver itself.

Now just need to make mplayer works with gui (overlay driver i mean), and make p96_pip driver as default ,and if it not present , switch back to the cgx_wpa , and then release.

Last edited by kas1e on 29-Oct-2011 at 10:30 AM.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

As I explained many times before, the alignment bug in p96_pip comes from using the width of pixel to calculate the byte width this is wrong, there is accurately possible to read out number of bytes per row from picasso96.

Last edited by NutsAboutAmiga on 29-Oct-2011 at 11:32 AM.

_________________
http://lifeofliveforit.blogspot.no/
Facebook::LiveForIt Software for AmigaOS

@NutsAboutAmiga

What about fixing the p96_pip.c driver in the mplayer then ? Source are here.

Let me know when you will finish it, i will just include it to mplayer.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

The code is changed a lot it will take some time to look it over.

_________________
http://lifeofliveforit.blogspot.no/
Facebook::LiveForIt Software for AmigaOS

@kas1e

what???

static int draw_slice(uint8_t *image[], int stride[], int w,int h,int x,int y)
{
// to be implemented - find non-PIP equivalent of p96PIP_GetTags()
return -1;
}

your are redoing it?

_________________
http://lifeofliveforit.blogspot.no/
Facebook::LiveForIt Software for AmigaOS

@NutsAboutAmiga

There is version which we strip to make it works (all unsed gadget removed and stuff). That one will be better for understanding. Prepare that thre is a lot of code which just make no sense.

Quote:

your are redoing it?

No, its from mplayer-google-page as you can see.

ops. i notice that i point you on wrong file (vo_p96.c), what is plain p96 impelmetation on which Varthall works for now, our one are vo_p96pip.c . Anyway, just grab version which i upload

Last edited by kas1e on 29-Oct-2011 at 11:50 AM.
Last edited by kas1e on 29-Oct-2011 at 11:48 AM.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

Did you read what i wrote before about overlay/compositing ?

_________________
Sam 460EX, 2Gb Ram, Radeon R7 250, AmigaOS4.1 FE
A4000 PPC604@233, Mediator
A1200 PPC603@160, Mediator
uA1 G3@800, 512 Mb [sold]

@kas1e

line 1965

change from:

srcdata = (ULONG *) ((uint32)ri.Memory + ( ( (y * image_width) + x) * 2));

change to:

srcdata = (ULONG *) ((uint32)ri.Memory + ( ( (y * image_byte_width) + x) * 2));

_________________
http://lifeofliveforit.blogspot.no/
Facebook::LiveForIt Software for AmigaOS

@SOFISTISOFTWARE

Yes, but for now all what i want its to fix overlay alignment, fix to make it works with gui, make proper release without crashes on exit, and then will take a break. Sources will be uploaded of course, anyone can add it.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@SOFISTISOFTWARE

MorphOS overlay supports YUV420 and triple buffering overlay since years, and apparently this p96pip driver now also does as well, reusing the original cgx blitting code.
So there's not anything more to do there.

Last edited by Fab on 29-Oct-2011 at 12:04 PM.

@NutsAboutAmiga

Quote:

change to: srcdata = (ULONG *) ((uint32)ri.Memory + ( ( (y * image_byte_width) + x) * 2));

error: image_byte_width undeclared.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

put this on line 1666

int image_byte_width;

put this on line 1673.

image_byte_width = p96GetBitMapAttr( bm ,P96BMA_BYTESPERROW);

Last edited by NutsAboutAmiga on 29-Oct-2011 at 12:11 PM.
Last edited by NutsAboutAmiga on 29-Oct-2011 at 12:09 PM.
Last edited by NutsAboutAmiga on 29-Oct-2011 at 12:05 PM.

_________________
http://lifeofliveforit.blogspot.no/
Facebook::LiveForIt Software for AmigaOS

@kas1e

ok i understood, but that thing seems very intersting, isn't it? With you current release i've problem with some avi files with audio speed and if you close some videos and try to open somenthing else mplayer doesn't respond, please check, my system is a Sam460 up3

_________________
Sam 460EX, 2Gb Ram, Radeon R7 250, AmigaOS4.1 FE
A4000 PPC604@233, Mediator
A1200 PPC603@160, Mediator
uA1 G3@800, 512 Mb [sold]

@SOFISTISOFTWARE
Quote:

ok i understood, but that thing seems very intersting, isn't it? With you current release i've problem with some avi files with audio speed and if you close some videos and try to open somenthing else mplayer doesn't respond, please check, my system is a Sam460 up3

Wait next release, hope all will be well.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@NutsAboutAmiga

For p96GetBitMapAttr say no declared, for P96GetBitMapAttr says on compiling stage about "implict declaration" (while i include proto/Picasso96API.h) and on linking stage undefined reference to "P96GetBitMapAttr"

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

OK, I see what I can find in some other src code.

_________________
http://lifeofliveforit.blogspot.no/
Facebook::LiveForIt Software for AmigaOS

@NutsAboutAmiga

Found it in the libraryes/picasso96.h . so for now have:

inlclude proto/picasso96api.h
include libraries/picasso96.h

compiles fine, linking fine, time to test

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

x

Last edited by NutsAboutAmiga on 29-Oct-2011 at 12:24 PM.

_________________
http://lifeofliveforit.blogspot.no/
Facebook::LiveForIt Software for AmigaOS