@kas1e

See where this GetTimer is called from in the stacktrace.

@Fab

From osdeps/timer_morphos:31 (that from the function GetTimer().

And that crash come from the GetRelativeTime(), which are in the osdeps/timer_morphos:50 by stack trace.

And all of this come from the main / mplayer.c : 3208 , which are:

GetRelativeTime(); // __MORPHOS__

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

Weird that it would crash, unless if called from another thread (which is not the case here).
So i still suspect the p96pip driver reinitializes something there, in openlibs or whatever.

@Fab

You are right, that p96-driver use in the config() fucntion something like:

if (hasGUI == TRUE)
{
TimerInit();
TimerReset(RESET_TIME);
}

(right before planar_2_chunky defines). And TimerInit() open the timer.device in the vo_p96pip_stuff.c - > reiniti of timer -> crash. Disabling of that crap solve the problems.

For now in the "preferences" i still can't see p96_pip (only cgx_wpa)

And dunno how to do by default usage of the p96_pip, and, fallback to cgx_wpa by default if it not works.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

Tip for speed and another simple benchmark.

mplayer has often multiple codecs for decoding a specific type of video or especially audio. So for example, I did mplayer -ac help and searched it (with pipe and grep) for "aac". There are two options, faad and ffaac. ffaac is much faster, so it's better for realtime when you don't have extra CPU time.

MUI mplayer is really fast with this. MPlayer SVN-r29532 spent 100 proportional seconds decoding and playing mp4 muxed AAC (with ffaac), whereas MUI mplayer used 79 seconds. For some reason, the difference grows a lot, if there are "distractions" in the background in the form of other tasks - in this case it was MUI OWB.

Last edited by Thematic on 29-Oct-2011 at 05:35 PM.
Last edited by Thematic on 29-Oct-2011 at 05:35 PM.

_________________
: AmigaOneXE (unmod.) 750FX/512 MB +stuff & AmigaOS 4.(0|1)
: A1200/68060&96MB/SCSI/EM1200-Voodoo3 & OS 3.5
: A500/1MB
: Pegasos (ff) 512 MB & MorphOS
Praise seitan.

@kas1e

Is it listed in -vo help ?

Last edited by Thematic on 29-Oct-2011 at 05:37 PM.

_________________
: AmigaOneXE (unmod.) 750FX/512 MB +stuff & AmigaOS 4.(0|1)
: A1200/68060&96MB/SCSI/EM1200-Voodoo3 & OS 3.5
: A500/1MB
: Pegasos (ff) 512 MB & MorphOS
Praise seitan.

@Thematic

Yes. Its just need add some bits to the gui related code (i assume gui/morphos/gui.c) , and somehow make to do it default, and fallback to cgx_wpa when overlay no available.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

First, in p96pip driver, control() function, you must advertise this driver has GUI support by adding in the switch case:

case VOCTRL_GUISUPPORT:
return VO_TRUE;


And it should be all that's needed to appear in the GUI output drivers.

@Fab
Quote:

First, in p96pip driver, control() function, you must advertise this driver has GUI support by adding in the switch case

Yeah, that works, cool !

Now, all what is need its just make it default, and fallback to cgx_wpa if that not enabled. I assume choicing p96_pip in the prefs and use "save" are the suck-way, and need to change some lines in the preferenseclass.c ?

And another question (maybe last one) :

In the p96 driver, there is function Check_Events present, which check keys (vanilla, raw ones and so on). So, over almost every key, there is used some kind of command like for example for dbl-clicking to make fullscreen:

Quote:

put_command0(MP_CMD_VO_FULLSCREEN);

The put_command0() function itself are based on some arexx-stuff, which imho done different on your version.

So, the question is: can i somehow send MP_CMD_VO_FULLSCREEN to mplayer, by something like "mplayer_send_command(MP_CMD_VO_FULLSCREEN); ?

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

try to use:

put_command0(MP_CMD_VO_FULLSCREEN);

[Edit]
Sorry
there is another method.. i will search

Last edited by afxgroup on 29-Oct-2011 at 06:47 PM.

_________________
http://www.amigasoft.net

@kas1e

BRAVO !

_________________
Sam 460EX, 2Gb Ram, Radeon R7 250, AmigaOS4.1 FE
A4000 PPC604@233, Mediator
A1200 PPC603@160, Mediator
uA1 G3@800, 512 Mb [sold]

@kas1e

The order the drivers appear in the cycle is the same as you put them in video_out.c. So just put p96pip before wpa.

Alternatively, you could specify the list of possible drivers in conf/config (see MorphOS Mplayer archive, even if that line is actually commented, it's there for reference).

As for doubleclicking, the event is already caught by the event handler in cgxcommon.c and MPlayer logic.

It's pointless to add hardcoded fullscreen switch on doubleclicking in the video driver itself (besides some people hate switching to fullscreen on doubleclick, so it really shouldn't be hardcoded).

It's simply done by binding the event in the config file conf/input.conf with MOUSE_BTN0_DBL vo_fullscreen (it's also supplied in MorphOS MPlayer archive).

Last edited by Fab on 29-Oct-2011 at 06:49 PM.

@afxgroup

put_command0 are your port specific , and as i see based on Arexx (which done on the fab's code different) , so if i will enable that usage, i can bork arexx-related parts, because of that trying to found a way to send commands without specific functions from your one.

For now all the put_command0 in the p96 driver are commented (just because of undefs).

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

Don't don't don't. See previous post.

@kas1e

try something like:

Quote:

mp_cmd_t * cmd = malloc(sizeof(mp_cmd_t)); if(cmd) { cmd->pausing = 0; cmd->id = MP_CMD_VO_FULLSCREEN; cmd->name = strdup("fullscreen"); cmd->nargs = 0; if(mp_input_queue_cmd(cmd) == 0) { mp_cmd_free(cmd); } }

watch out that it is not tested at all. You can take a look at argument name too (if it is correct)

Last edited by afxgroup on 29-Oct-2011 at 06:52 PM.

_________________
http://www.amigasoft.net

Just a big NO NO.

@fab
Quote:

The order the drivers appear in the cycle is the same as you put them in video_out.c. So just put p96pip before wpa.

That one not helps

Quote:

Alternatively, you could specify the list of possible drivers in conf/config (see MorphOS Mplayer archive, even if that line is actually commented, it's there for reference).

That one too (or i do something wrong). I just add here:
vo=p96_pip - no luck, then i try
vo=p96_pip::PLANAR,p96_pip (i.e. the same as commented string) - no luck as well.

But config file itself reads and works (because i change autosync from 30 to 20, and it appears in the gui-prefs)

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@Fab

why no? this just put a command in the mplayer queue. what's wrong with it?

_________________
http://www.amigasoft.net

@kas1e

I'm pretty sure it helps, so you probably didn't move the driver entry to the correct place (like you moved the declaration only but not the actual entry in the array...

As for the config file, the gui actually uses gui.conf.

@afxgroup

The code itself is correct (well looks like), but my point is you shouldn't hardcode this kind of thing, especially when MPlayer lets you do it already by simple configuration options.

Last edited by Fab on 29-Oct-2011 at 07:04 PM.

@Fab

Blah, dunno what i do lately, but now i just can't see my p96 driver when do "mplayer -vo help". But, i see it from gui, and i can use it from gui. But not from command line. Uhm..

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites