@kas1e

Just upload the video_out.c somewhere.

@Fab
Quote:

Just upload the video_out.c somewhere.

Was some usuall mess, now all is fine. By default and for gui and for command line overlay, its also in the prefs-option visibly, and cgx_wpa works as well if choicen.

Quote:

As for doubleclicking, the event is already caught by the event handler in cgxcommon.c and MPlayer logic. It's pointless to add hardcoded fullscreen switch on doubleclicking in the video driver itself (besides some people hate switching to fullscreen on doubleclick, so it really shouldn't be hardcoded). It's simply done by binding the event in the config file conf/input.conf with MOUSE_BTN0_DBL vo_fullscreen (it's also supplied in MorphOS MPlayer archive).

The problem is that P96_CheckEvents function already here to catch up all the quits/dbl-clicks and stuff. If i will remove it at all, i should replace it by something like this by logic. That what i have:

static void check_events(void)
{
p96_CheckEvents(my_window, &window_heigh, &window_width, &win_left, &win_top);
.....
}

I check your vo_cgx_overlay.c , and you also have Cgx_CheckEvents() function, which in the cgx_common.c . Can i just reuse it in the p96 check_events ? (i.e just use not p96_CheckEvents(), but Cgx_CheckEvents()) ?

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

Quote:

Was some usuall mess, now all is fine. By default and for gui and for command line overlay, its also in the prefs-option visibly, and cgx_wpa works as well if choicen.

_________________
BACK FOR THE FUTURE

http://www.betatesting.it/backforthefuture

Sam440ep Flex 800 Mhz 1 GB Ram + AmigaOS 4.1 Update 6
AmigaOne XE G3 800 Mhz - 640 MB Ram - Radeon 9200 SE + AmigaOS 4.1 Update 6

@kas1e

Apart from the blankers enable/disable function and the transparency borders in NOBORDER and DISAPBORDER modes, the cgx code should work as-is, since it's just about Intuition, anyway. So yes, you can reuse it, and you'd better do it, even.

And anyway, you already use it for the cgx_wpa mode, so it will work just fine.

Last edited by Fab on 29-Oct-2011 at 08:29 PM.

@fab
Seems i can :) Just reuse your cgx_checkevents, and it works. Expectually close-gadget and dbl-click works. But "esc" for quit or "p" for pause are not, but i assume its all about config files ?

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

No idea about that. The events are surely caught, but you can always add debug in the cgx_common.c for these and make sure they're sent.

And p/esc are mapped by default in MPlayer, so it should work, unless conf/input.conf redefines them (badly).

@Fab

Found the roots: classic mess with idcmp flags. In the p96_openwindow was:

Quote:

WA_IDCMP, IDCMP_NEWSIZE | IDCMP_MOUSEBUTTONS | IDCMP_RAWKEY | IDCMP_VANILLAKEY | IDCMP_CLOSEWINDOW | IDCMP_MENUPICK | IDCMP_MOUSEMOVE | IDCMP_IDCMPUPDATE | IDCMP_CHANGEWINDOW | IDCMP_GADGETUP | IDCMP_GADGETDOWN,

And your one are:

Quote:

WA_IDCMP, IDCMP_MOUSEBUTTONS | IDCMP_INACTIVEWINDOW | IDCMP_ACTIVEWINDOW | IDCMP_CHANGEWINDOW | IDCMP_MOUSEMOVE | IDCMP_REFRESHWINDOW | IDCMP_RAWKEY /*| IDCMP_VANILLAKEY*/ IDCMP_CLOSEWINDOW | IDCMP_NEWSIZE,

After putting your ones to the opening of window, all start to works.

Dunno through what combination bork it , but i remember with my old tests with all of this, if you use for example rawkey and vanilla at one time, you will out of luck with some keys (like pgdown, pgup, etc). Looks like there is something of this kind

For now, all what is left to fix, is:

- in the overlays mode window a bit bigger at bottom, because there was some old gadgets, which i remove, but somethere is still left to update the size of window.

- in the full screen, the backgorund color of the screen are white, and not black (that a bit suck).

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

Hey Roman i note one thing a bit annoying with the current public release (cgx_wpa)
If i close the window of the video the entire MPlayer will be closed, is it possible to just close the window of the video closed manually mantain the GUI opened ?

And just another very small one: the Workbench title clicking on the video's window is showed as:

Quote:

MPlayer xxxxx for MorphOS

When "xxxxx" should be the title of the video i think (?), but still only "xxxxx" and of course the "MorphOS" reference must be changed to "AmigaOS"

Just very not necessary and small one of course but while you are working to complete it

BTW: Once overlay is enabled i hope to see less slowdown in general and better sinch, expecially on big videos, it's time to test maybe

Last edited by samo79 on 29-Oct-2011 at 09:18 PM.
Last edited by samo79 on 29-Oct-2011 at 09:11 PM.

_________________
BACK FOR THE FUTURE

http://www.betatesting.it/backforthefuture

Sam440ep Flex 800 Mhz 1 GB Ram + AmigaOS 4.1 Update 6
AmigaOne XE G3 800 Mhz - 640 MB Ram - Radeon 9200 SE + AmigaOS 4.1 Update 6

@samo79

That's on purpose. Press stop if you want to close the video window (but to be honest, GUI is more practical in embedded mode, anyway)

@Fab

Yes once overlay is availible i will use the embedded window (all in one single window) for sure, it's one of the best feature comparing to the Reaction one so i can't miss this functionality

But for the moment i find it quite strange to press stop instead, aniway

_________________
BACK FOR THE FUTURE

http://www.betatesting.it/backforthefuture

Sam440ep Flex 800 Mhz 1 GB Ram + AmigaOS 4.1 Update 6
AmigaOne XE G3 800 Mhz - 640 MB Ram - Radeon 9200 SE + AmigaOS 4.1 Update 6

@Fab
Btw, i notice now, that in full-sreen mode keys not works (not esc, not p). Imho need to change somethere something as in case with p96_checkevents ?

@samo79
Quote:

BTW: Once overlay is enabled i hope to see less slowdown in general and better sinch, expecially on big videos,

You can hope of course, but i do not know what will happens :) But for 1000 euro for fab, and 500 for me, we imho will in interest to make hopes reality :)

Anyway, i think all will be fine.

Quote:

it's time to test maybe

I will just upload on os4depot version which not crashes on exit, have alignment and overlay support as it should. All the other bugs can be reported, but for now i really do not know if i will have motivation to worry about os4 at all. Maybe if only for money, then why not.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@fab

Ah and of course if you add any Locale support in the near future i will glad to start translate the entire program

_________________
BACK FOR THE FUTURE

http://www.betatesting.it/backforthefuture

Sam440ep Flex 800 Mhz 1 GB Ram + AmigaOS 4.1 Update 6
AmigaOne XE G3 800 Mhz - 640 MB Ram - Radeon 9200 SE + AmigaOS 4.1 Update 6

@samo79
Quote:

Yes once overlay is availible i will use the embedded window (all in one single window) for sure, it's one of the best feature comparing to the Reaction one so i can't miss this functionality

There is no embedded gui mode. Its other drivers, which works only on cgx, because with our p96 overlay we can't dynamically attach stuff to overlay windowses. So, no embedded mode of course.

And yep, i also found that closing of video should not close the whole gui.

@fab
Maybe i can by some easy way to avoid closing of mplayer by the closing of video-window ?

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

Quote:

You can hope of course, but i do not know what will happens :) But for 1000 euro for fab, and 500 for me, we imho will in interest to make hopes reality :)

hahaha

Quote:

I will just upload on os4depot version which not crashes on exit, have alignment and overlay support as it should. All the other bugs can be reported, but for now i really do not know if i will have motivation to worry about os4 at all. Maybe if only for money, then why not.

Yep, for what i see atm this port seems already done, maybe there are some very small things here and there but it's ok in general, of course before say i need to test the sinch in videos, the general speed and so on but if all of that will be ok the port is 100% done

About money, motivations and so on you are right, expecially you all needs some money to complete MUI OWB (and for all the previews job), sinch to latest 1.14, HTML5 etc ... well just open this bounty mate, what you are wait ?

Quote:

There is no embedded gui mode. Its other drivers, which works only on cgx, because with our p96 overlay we can't dynamically attach stuff to overlay windowses. So, no embedded mode of course.

So we need a new p96 update to have it ? :-/

Last edited by samo79 on 29-Oct-2011 at 09:39 PM.

_________________
BACK FOR THE FUTURE

http://www.betatesting.it/backforthefuture

Sam440ep Flex 800 Mhz 1 GB Ram + AmigaOS 4.1 Update 6
AmigaOne XE G3 800 Mhz - 640 MB Ram - Radeon 9200 SE + AmigaOS 4.1 Update 6

@samo79
Quote:

About money, motivations and so on you are right, expecially you all needs some money to complete MUI OWB (and for all the previews job), sinch to latest 1.14, HTML5 etc ... well just open this bounty mate, what you are wait ?

We do not know how much for now. And the problem with muiowb, that mediplayer for html5 done not by fab, and he can't open source of it. So, need to motivate him to make new version. Just ask him if he in interest about :)

Quote:

So we need a new p96 update to have it ? :-/

Some hacks is possible, maybe it possible to somehow emualte it via cgxvideo.library emulation (but it will be in SW mode anyway, without overlay, even if it will works at all) and so on. But it will be not like reuse fab's code.

Last edited by kas1e on 29-Oct-2011 at 09:43 PM.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

I mail him already but as we are here now (and he is here aswell) .. maybe he can say somethings now ?

Quote:

Some hacks is possible, maybe it possible to somehow emualte it via cgxvideo.library emulation (but it will be in SW mode anyway, without overlay, even if it will works at all) and so on. But it will be not like reuse fab's code.

That's very sad !
This was a main feature imho, maybe if not so hard we can ask to someone that can implement this soon on p96? (maybe Hans ?)

What do you think ?

Last edited by samo79 on 29-Oct-2011 at 09:47 PM.

_________________
BACK FOR THE FUTURE

http://www.betatesting.it/backforthefuture

Sam440ep Flex 800 Mhz 1 GB Ram + AmigaOS 4.1 Update 6
AmigaOne XE G3 800 Mhz - 640 MB Ram - Radeon 9200 SE + AmigaOS 4.1 Update 6

@samo79

Quote:

That's very sad ! This was a main feature imho, maybe if not so hard we can ask to someone that can implement this soon ? (maybe Hans ?) What do you think ?

You know the answers already: p96 are abandoned, and will be replaced. But you know yourself that it will take about 3-5 years in the best way. So , better even not to worry at all, or, implement that "hack ways", about which nutsaboutamiga says on some pages early.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites

@kas1e

About the p/esc keys not working, i guess it's because you don't have the expected idcmp flags set in the fullscreen mode when opening the window (just like in window mode before).

As for binding the window close event to stop, the easiest would be to call "mp_input_queue_cmd(mp_input_parse_cmd("stop")); on IDCMP_CLOSEWINDOW event.

By the way, i don't know if you tested it or not, but check that pressing MMB in overlay window toggles control panel display on/off.

Last edited by Fab on 29-Oct-2011 at 09:56 PM.
Last edited by Fab on 29-Oct-2011 at 09:50 PM.

@kas1e

Mmm :-/ i will send a nudge to Hans just to inform him then we will see what happen ..

Hey the big Fab release another OWB beauty !
Thanks mate !

_________________
BACK FOR THE FUTURE

http://www.betatesting.it/backforthefuture

Sam440ep Flex 800 Mhz 1 GB Ram + AmigaOS 4.1 Update 6
AmigaOne XE G3 800 Mhz - 640 MB Ram - Radeon 9200 SE + AmigaOS 4.1 Update 6

@Fab

Quote:

As for binding the window close event to stop, the easiest would be to call "mp_input_queue_cmd(mp_input_parse_cmd("stop")); on IDCMP_CLOSEWINDOW event.

But it possible to close the video-window, without closing of the whole mplayer ? I.e. not just stop video, but close video window ?

Quote:

By the way, i don't know if you tested it or not, but check that pressing MMB in overlay window toggles control panel display on/off.

Yep, works.

Last edited by kas1e on 29-Oct-2011 at 10:05 PM.

_________________
Join us to improve dopus5!
zerohero's mirror of os4/os3 crosscompiler suites