Poster | Thread |
xeron
| |
MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 16:34:48
| | [ #1 ] |
|
|
|
Elite Member |
Joined: 22-Jun-2003 Posts: 2440
From: Weston-Super-Mare, Somerset, England, UK, Europe, Earth, The Milky Way, The Universe | | |
|
| Here is a patch:
MemPatch
Its a quick and dirty hack I just knocked together in 5 mins. It basically patches the 68k AllocMem(), and AllocVec() functions and causes them to allocate an extra 8 bytes at the start and end of the buffer. It also places the requested allocation size just before the returned buffer in AllocVec() which some badly written software use.
I don't recommend installing this patch as a matter of course, only install it if you find it makes a particular piece of software you need start working.
Its a very ugly hack, and I would hope that someone could take this patch and make a per-application patch instead of a global patch like this one. (in other words, I hope this becomes obsolete very soon :)
Someone told me that it got Final Writer running under OS4 Final, although your mileage may vary.
(Oh, and in case someone was wondering, it wasn't the missing size field from AllocVec that prevents FW from working; it just happily overwrites the ends of its buffers). _________________ Playstation Network ID: xeron6 |
|
Status: Offline |
|
|
xeron
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 16:36:53
| | [ #2 ] |
|
|
|
Elite Member |
Joined: 22-Jun-2003 Posts: 2440
From: Weston-Super-Mare, Somerset, England, UK, Europe, Earth, The Milky Way, The Universe | | |
|
| Oh yes! If you're putting it in your startup-sequence, DO NOT forget the "Run NIL:" since you can't quit the patch and it'll halt the bootsequence forever. _________________ Playstation Network ID: xeron6 |
|
Status: Offline |
|
|
ChrisH
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 16:45:30
| | [ #3 ] |
|
|
|
Elite Member |
Joined: 30-Jan-2005 Posts: 6679
From: Unknown | | |
|
| @xeron That sounds like a good compliment to MemTrailer, which can be got from the Aminet. I found that helped stop Wordworth from crashing under Amithlon/WinUAE. _________________ Author of the PortablE programming language. It is pitch black. You are likely to be eaten by a grue... |
|
Status: Offline |
|
|
xeron
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 16:47:35
| | [ #4 ] |
|
|
|
Elite Member |
Joined: 22-Jun-2003 Posts: 2440
From: Weston-Super-Mare, Somerset, England, UK, Europe, Earth, The Milky Way, The Universe | | |
|
| @ChrisH
Having looked up memtrailer, I don't recommend running mempatch and memtrailer at the same time. _________________ Playstation Network ID: xeron6 |
|
Status: Offline |
|
|
srupprecht
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 17:00:48
| | [ #5 ] |
|
|
|
Regular Member |
Joined: 23-Sep-2003 Posts: 166
From: Unknown | | |
|
| I already wrote a program called MemHack (actually it's the ADDCHIPMEM code from SetPatch) which does almost the same thing but it's a little more robust as it does not peek memory areas it didn't allocate. Checking for a 'os4x' signature, that's what MemPatch does, is a bit dangerous as it can cause unexpected visits from India. _________________ Stephan Rupprecht - AmigaOS4 developer |
|
Status: Offline |
|
|
xeron
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 17:03:42
| | [ #6 ] |
|
|
|
Elite Member |
Joined: 22-Jun-2003 Posts: 2440
From: Weston-Super-Mare, Somerset, England, UK, Europe, Earth, The Milky Way, The Universe | | |
|
| @srupprecht
Yes, I'm fully aware that its not the best of ideas, but I figured the worst case would be a recoverable DSI from a 68k program that was already running when MemPatch was run. In most cases the check is fine, especially if MemPatch was run at the start of startup-sequence (not much 68k code running then). It seemed a better idea than just adding 16 to the allocation size and subtracting 8 from the buffer address without any kind of check, since that would probably be a much worse "crash and burn".
I wasn't aware of MemHack.
Edit: And as far as I'm aware "ADDCHIPMEM" doesn't get FinalWriter running, which MemPatch does. Last edited by xeron on 29-Dec-2006 at 05:09 PM. Last edited by xeron on 29-Dec-2006 at 05:08 PM. Last edited by xeron on 29-Dec-2006 at 05:04 PM.
_________________ Playstation Network ID: xeron6 |
|
Status: Offline |
|
|
srupprecht
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 17:15:44
| | [ #7 ] |
|
|
|
Regular Member |
Joined: 23-Sep-2003 Posts: 166
From: Unknown | | |
|
| @xeron
I wrote MemHack yesterday, so you couldn't know it SetPatch does not solve the problem because MemHack is an extended version which also emulates MEMF_FAST (SP only patches MEMF_CHIP allocations). _________________ Stephan Rupprecht - AmigaOS4 developer |
|
Status: Offline |
|
|
dietmar
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 17:19:03
| | [ #8 ] |
|
|
|
Cult Member |
Joined: 1-May-2003 Posts: 532
From: Unknown | | |
|
| If this patch does what it claims, it will allow older GoldED version to run under OS4, too, including the free GoldED AIX version. They require an AmigaOS3-style implementation of AllocVec(). |
|
Status: Offline |
|
|
mpiva
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 17:27:19
| | [ #9 ] |
|
|
|
Regular Member |
Joined: 3-Aug-2005 Posts: 202
From: Alberta, CAN | | |
|
| This is great news. Can anyone else confirm that FinalWriter97 does indeed work with this? |
|
Status: Offline |
|
|
Frank
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 18:02:40
| | [ #10 ] |
|
|
|
Member |
Joined: 7-Jun-2003 Posts: 46
From: Suffolk, England | | |
|
| @mpiva
I`ve got FW to load documents can`t save crashes on printing. I`ll keep playing though.
OOPS! Buggered up installation of FW so ignore me sorry.
Cheers Frank Last edited by Frank on 29-Dec-2006 at 06:46 PM.
|
|
Status: Offline |
|
|
ssolie
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 18:29:03
| | [ #11 ] |
|
|
|
Elite Member |
Joined: 10-Mar-2003 Posts: 2755
From: Alberta, Canada | | |
|
| @mpiva No problems with FinalWriter here on AmigaOS 4.0 Final (clean install as per documentation).
I can open/save/print without any issues.
_________________ ExecSG Team Lead |
|
Status: Offline |
|
|
redfox
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 19:22:25
| | [ #12 ] |
|
|
|
Elite Member |
Joined: 7-Mar-2003 Posts: 2076
From: Canada | | |
|
| @mpiva
I can confirm that Final Writer 97 launches ok with mempatch in place, but I may have something else going on here with my installation. As long as I don't make a new document or modify and existing one, seems to work fine. I can quit and relaunch ok several times. As soon as I save a change to a document, the fun starts. I can quit ok but if I relaunch Final Writer 97 it crashes. IBrowse crashes as well after I modify a document with Final Writer 97. Not sure if that is just coincidence.
--- redfox
|
|
Status: Offline |
|
|
xeron
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 19:35:26
| | [ #13 ] |
|
|
|
Elite Member |
Joined: 22-Jun-2003 Posts: 2440
From: Weston-Super-Mare, Somerset, England, UK, Europe, Earth, The Milky Way, The Universe | | |
|
| @dietmar
Where can I download the free GoldEd AIX version to verify? _________________ Playstation Network ID: xeron6 |
|
Status: Offline |
|
|
redfox
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 19:46:53
| | [ #14 ] |
|
|
|
Elite Member |
Joined: 7-Mar-2003 Posts: 2076
From: Canada | | |
|
| @mpiva
I reinstalled Final Writer 97 from a different back-up and now it is working ok with mempatch in place. load/edit/save ok now. Relaunch ok.
--- redfox
Last edited by redfox on 29-Dec-2006 at 07:55 PM.
|
|
Status: Offline |
|
|
redfox
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 19:53:01
| | [ #15 ] |
|
|
|
Elite Member |
Joined: 7-Mar-2003 Posts: 2076
From: Canada | | |
|
| @xeron
Final Writer 97 working fine here now with mempatch in place.
very much indeed. redfox |
|
Status: Offline |
|
|
TrevorDick
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 20:09:51
| | [ #16 ] |
|
|
|
Elite Member |
Joined: 30-Dec-2004 Posts: 2678
From: Wellington | | |
|
| @redfox
I can also confirm that FW97 appears to work OK with Mempatch activated. Unfortunately it seems to make IBrowse crash. Will investigate further.
TrevorDick
_________________ No, I don't need no reason, I'm just breezin' |
|
Status: Offline |
|
|
Toaks
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 20:38:11
| | [ #17 ] |
|
|
|
Elite Member |
Joined: 10-Mar-2003 Posts: 8042
From: amigaguru.com | | |
|
| @TrevorDick
Quote:
TrevorDick wrote: @redfox
I can also confirm that FW97 appears to work OK with Mempatch activated. Unfortunately it seems to make IBrowse crash. Will investigate further.
TrevorDick
|
I can confirm that problem indeed.... Final writer works with patch but then ibrowse dusted an DSI, most likely repairable if you put mempatch higher up in the startup-sequence.
_________________ See my blog and collection website! . https://www.blog.amigaguru.com |
|
Status: Offline |
|
|
redfox
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 21:44:11
| | [ #18 ] |
|
|
|
Elite Member |
Joined: 7-Mar-2003 Posts: 2076
From: Canada | | |
|
| @TrevorDick
IBrowse crashes here too. At first I thought it was random.
--- redfox
Last edited by redfox on 29-Dec-2006 at 11:04 PM.
|
|
Status: Offline |
|
|
dietmar
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 22:13:49
| | [ #19 ] |
|
|
|
Cult Member |
Joined: 1-May-2003 Posts: 532
From: Unknown | | |
|
| @xeron: Nowhere (it was a 3-day free download opportunity earlier this year but it's not freely distributable per se). |
|
Status: Offline |
|
|
buzz
| |
Re: MemPatch (FinalWriter users read this!) Posted on 29-Dec-2006 22:18:56
| | [ #20 ] |
|
|
|
Member |
Joined: 16-Dec-2006 Posts: 40
From: Unknown | | |
|
| @xeron
Stop coding on other things and do the hivelytracker release (os4/68k v1.2) damnit :D
|
|
Status: Offline |
|
|