Poster | Thread |
Georg
|  |
Re: Timberwolf now open sourced!!! Posted on 19-Sep-2016 17:53:09
| | [ #181 ] |
|
|
 |
Regular Member  |
Joined: 14-May-2003 Posts: 452
From: Unknown | | |
|
| @Mr_Capehill
I would have said nothing will happen, but maybe AOS4 is different.
Otherwise one could maybe do:
yield_help_task = high pri task which does
while(1) { Wait(SIGBREAKF_CTRL_F); }
my_yield() { Signal(yield_helper_task, SIGBREAKF_CTRL_F); }
|
|
Status: Offline |
|
|
broadblues
 |  |
Re: Timberwolf now open sourced!!! Posted on 19-Sep-2016 18:17:29
| | [ #182 ] |
|
|
 |
Amiga Developer Team  |
Joined: 20-Jul-2004 Posts: 4449
From: Portsmouth England | | |
|
| @Georg
Quote:
The code in the link has the WaitIO() call inside the "if(!CheckIO" block.
|
AARG! didn't see your semi colon, need new glasses, sorry.
OT that's one of the reasons I never use trailing clauses and *always* use braces even for single statement ifs and whiles, much much clearer to read...
As I said earlier I now think the CheckIO() is completely redundant if even [perhaps amistake. The code I use in similar circumstances looks like:
if(timerstarted) // mustn't pass a timer that has never been started to AbortIO() { AbortIO() WaitIO() SetSignal() // if timer had finished before the WaitIO() signal won;t be cleared so clear it ourselves. }
[edit] Typos grammer and general keyboard incomptetence///Last edited by broadblues on 19-Sep-2016 at 07:16 PM.
_________________ BroadBlues On Blues BroadBlues On Amiga Walker Broad |
|
Status: Offline |
|
|
salass00
|  |
Re: Timberwolf now open sourced!!! Posted on 19-Sep-2016 19:52:20
| | [ #183 ] |
|
|
 |
Elite Member  |
Joined: 31-Oct-2003 Posts: 2707
From: Finland | | |
|
| @Georg
AFAIK this should work as yield() on AmigaOS:
void amiga_yield() { struct Task *me = FindTask(NULL); SetTaskPri(me, me->tc_Node.ln_Pri); }
|
|
Status: Offline |
|
|
NutsAboutAmiga
|  |
Re: Timberwolf now open sourced!!! Posted on 19-Sep-2016 21:29:27
| | [ #184 ] |
|
|
 |
Elite Member  |
Joined: 9-Jun-2004 Posts: 12960
From: Norway | | |
|
| |
Status: Offline |
|
|
Plaz
|  |
Re: Timberwolf now open sourced!!! Posted on 19-Sep-2016 21:34:54
| | [ #185 ] |
|
|
 |
Super Member  |
Joined: 2-Oct-2003 Posts: 1573
From: Atlanta | | |
|
| @Mr_Capehill
Interesting, what's the story behind that repository?
Plaz |
|
Status: Offline |
|
|
NutsAboutAmiga
|  |
Re: Timberwolf now open sourced!!! Posted on 19-Sep-2016 21:51:40
| | [ #186 ] |
|
|
 |
Elite Member  |
Joined: 9-Jun-2004 Posts: 12960
From: Norway | | |
|
| @Georg
thread->md.task = IDOS->CreateNewProcTags( NP_Entry, threadCodeStart, NP_Input, IDOS->Open("CONSOLE:", MODE_OLDFILE), NP_CloseInput, TRUE, NP_Output, IDOS->Open("CONSOLE:", MODE_OLDFILE), NP_CloseOutput, TRUE, NP_StackSize, stackSize, NP_Name, thread->md.name, NP_EntryData, setupMsg, NP_Child, TRUE, NP_Cli, TRUE, TAG_DONE);
PR_ASSERT(thread->md.task != 0);
IExec->WaitPort(setupPort); IExec->GetMsg(setupPort);
IExec->FreeSysObject(ASOT_MESSAGE, setupMsg); IExec->FreeSysObject(ASOT_PORT, setupPort);
return PR_SUCCESS; }
this code looks bad too me, assuming always success is not a good idea, also the code can get stuck at WaitPort()
And also from PR_ASSERT seems to be used to validate success, that’s seams wrong. look at this docs:
https://opensource.apple.com/source/libsecurity_asn1/libsecurity_asn1-29908/lib/prlog.h https://en.wikipedia.org/wiki/Assert.h
The definitions PR_ASSERT and ASSERT as:
#define assert(ignore)((void) 0) #define PR_ASSERT(_exp) assert(_exp)
totally useless, unless in debug mode according to assert.h doc.
Last edited by NutsAboutAmiga on 20-Sep-2016 at 05:01 AM. Last edited by NutsAboutAmiga on 20-Sep-2016 at 04:59 AM. Last edited by NutsAboutAmiga on 19-Sep-2016 at 10:07 PM. Last edited by NutsAboutAmiga on 19-Sep-2016 at 10:03 PM.
_________________ http://lifeofliveforit.blogspot.no/ Facebook::LiveForIt Software for AmigaOS |
|
Status: Offline |
|
|
ferrels
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 5:15:51
| | [ #187 ] |
|
|
 |
Cult Member  |
Joined: 20-Oct-2005 Posts: 922
From: Arizona | | |
|
| @Deniil715
Quote:
@ferrels Please stop talking. You obviously know embarrassingly close to nothing about software development to comment on any time frames or porting effort regarding such a huge project as Firefox/Timberwolf. AmigaOS is totally alien to any other platform that porting anything bigger than a simple shell tool is a pain. The dependency tree of Firefox is monumental. I'm not claiming the Friedens are Gods, but it requires experience, talent and some serious dedication to even begin thinking about porting something like Firefox to AmigaOS, especially in the state AmigaOS was at the time. 2 (man-)years seems like a reasonable time to me. After getting 1.5 month salary for 2 years work they were probably pretty tired of the project, and then spending another month collecting the sources to make it compile in a generic environment (not only their own, most likely very custom build SDK setups) probably came very low on the priority list. |
Actually I know quite a bit about software development and porting on several platforms, but I focus primarily on OS X and Windows. I've also done quite a bit of my own development over the years for OS3 and Linux as well. See my website at http://lidarwidgets.com
I also just completed a total overhaul of the software found here to bring it into the world of 64-bit computing: http://www.galiander.ca/quikgrid/availability.html
So please don't talk out of your arse any further because you know nothing about me. You're making yourself look like just another fanboy with a man-crush on the Friedens.
Last edited by ferrels on 20-Sep-2016 at 05:51 AM. Last edited by ferrels on 20-Sep-2016 at 05:47 AM. Last edited by ferrels on 20-Sep-2016 at 05:41 AM.
|
|
Status: Offline |
|
|
Nibunnoichi
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 7:02:35
| | [ #188 ] |
|
|
 |
Cult Member  |
Joined: 18-Nov-2004 Posts: 972
From: Roma + Milano, Italia | | |
|
| @Mr_Capehill
Who's Ronnie Sahlberg? Is him around here?
_________________ Proud Amigan since 1987 Owner of various Commodore and a SAM440ep\OS4.1FE See them on http://retro.furinkan.org/ |
|
Status: Offline |
|
|
Mr_Capehill
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 13:25:07
| | [ #189 ] |
|
|
 |
Super Member  |
Joined: 15-Mar-2003 Posts: 1933
From: Yharnam | | |
|
| |
Status: Offline |
|
|
Mr_Capehill
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 13:25:35
| | [ #190 ] |
|
|
 |
Super Member  |
Joined: 15-Mar-2003 Posts: 1933
From: Yharnam | | |
|
| @NutsAboutAmiga
It's open source, you can fix it :)
|
|
Status: Offline |
|
|
broadblues
 |  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 14:36:59
| | [ #191 ] |
|
|
 |
Amiga Developer Team  |
Joined: 20-Jul-2004 Posts: 4449
From: Portsmouth England | | |
|
| @NutsAboutAmiga
Yes that code could be tightened up WRT to error chackig but there is nothing wrong with the PR_ASSERT being there. Assuming the code you linked to (from a different project I might add!) is the correct code for this context then it simply outputs some debug if the Process failed to start and will only do so in a debug build ie when NDEBUG is not present.
To say it's totally useless except in debug mode is like saying mplayer is useless for doing anything but playing videos.... it's what its for!
Last edited by broadblues on 20-Sep-2016 at 02:37 PM.
_________________ BroadBlues On Blues BroadBlues On Amiga Walker Broad |
|
Status: Offline |
|
|
broadblues
 |  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 14:41:26
| | [ #192 ] |
|
|
 |
Amiga Developer Team  |
Joined: 20-Jul-2004 Posts: 4449
From: Portsmouth England | | |
|
| @NutsAboutAmiga
Quote:
@Mr_Capehill
Should just hog multitasking, useless code.
|
I assume that the Permit() might trigger some evaulation of which task should run next by the scheduler, that's not documented, so not porrtable, but the authors of the code are also the authors of the ExecSG kernel core, so I guess they ought to know.
_________________ BroadBlues On Blues BroadBlues On Amiga Walker Broad |
|
Status: Offline |
|
|
NutsAboutAmiga
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 15:49:21
| | [ #193 ] |
|
|
 |
Elite Member  |
Joined: 9-Jun-2004 Posts: 12960
From: Norway | | |
|
| @Mr_Capehill
I only looked at the code, I don't have Linux setup here, only run AmigaOS4.1 and Windows10, none ideal to compile timberwolf.
It's not rally a matter of fixing it works as it is sort of, but it might fail. It matter of making it safe. It might explain way some people have no issue, and some do however. Or TW might fail in complete different place. _________________ http://lifeofliveforit.blogspot.no/ Facebook::LiveForIt Software for AmigaOS |
|
Status: Offline |
|
|
NutsAboutAmiga
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 15:53:04
| | [ #194 ] |
|
|
 |
Elite Member  |
Joined: 9-Jun-2004 Posts: 12960
From: Norway | | |
|
| @broadblues
I fixed many issues like that in mplayer too, one fix in that guarantees all threads to closed, before, libraries and devices are closed. And also I coded part of threading code so stops thread before closing window and so on, when your doing things in parallel, there might be many unexpected issues, if things crash under Linux all, you get is core dump, no harm done. If you crash a AmigaOS program, you might get memory corruption and system start acting strange or lockup.
I'm not here to scrutinize the code, but just barely barely suggest what might improve it. Last edited by NutsAboutAmiga on 20-Sep-2016 at 06:08 PM. Last edited by NutsAboutAmiga on 20-Sep-2016 at 03:59 PM. Last edited by NutsAboutAmiga on 20-Sep-2016 at 03:56 PM.
_________________ http://lifeofliveforit.blogspot.no/ Facebook::LiveForIt Software for AmigaOS |
|
Status: Offline |
|
|
Mr_Capehill
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 16:44:25
| | [ #195 ] |
|
|
 |
Super Member  |
Joined: 15-Mar-2003 Posts: 1933
From: Yharnam | | |
|
| @NutsAboutAmiga
Yeah, well, it was a bit tongue-in-cheek comment. There is lots of talk here but little action :)
I'm still happy that some people are trying to take a constructive angle into current situation. |
|
Status: Offline |
|
|
Mr_Capehill
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 16:45:49
| | [ #196 ] |
|
|
 |
Super Member  |
Joined: 15-Mar-2003 Posts: 1933
From: Yharnam | | |
|
| @salass00
Should there perhaps be a "Yield()" function in Exec? BZ time? |
|
Status: Offline |
|
|
wawa
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 17:07:08
| | [ #197 ] |
|
|
 |
Elite Member  |
Joined: 21-Jan-2008 Posts: 6259
From: Unknown | | |
|
| @NutsAboutAmiga
Quote:
I only looked at the code, I don't have Linux setup here, only run AmigaOS4.1 and Windows10, none ideal to compile timberwolf. |
as i said, should be easy to set up linux crosscompiler under vmplayer on win. |
|
Status: Offline |
|
|
NutsAboutAmiga
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 18:12:05
| | [ #198 ] |
|
|
 |
Elite Member  |
Joined: 9-Jun-2004 Posts: 12960
From: Norway | | |
|
| |
Status: Offline |
|
|
NutsAboutAmiga
|  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 18:27:36
| | [ #199 ] |
|
|
 |
Elite Member  |
Joined: 9-Jun-2004 Posts: 12960
From: Norway | | |
|
| |
Status: Offline |
|
|
broadblues
 |  |
Re: Timberwolf now open sourced!!! Posted on 20-Sep-2016 18:37:29
| | [ #200 ] |
|
|
 |
Amiga Developer Team  |
Joined: 20-Jul-2004 Posts: 4449
From: Portsmouth England | | |
|
| |
Status: Offline |
|
|